-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authorizer builder #250
Merged
Merged
authorizer builder #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geal
force-pushed
the
geal/authorizer-builder
branch
from
November 27, 2024 10:23
ccec5d5
to
2f11d04
Compare
CodSpeed Performance ReportMerging #250 will degrade performances by 10.44%Comparing Summary
Benchmarks breakdown
|
the performance regression is due to |
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #194, #193, #192
This adds an
AuthorizerBuilder
struct that is used to create anAuthorizer
. All of the mutable behaviour, like adding facts or executing Datalog rules is moved into the builder, while the authorizer is limited to read-only queries (still requiring self mutability to track execution time). TheAuthorizerBuilder
is compatible with snapshots, to store and reuse checks and policies. It has abuild
method taking a token as argument, and abuild_unauthenticated
for authorization without token.The builder APIs are alo changing. Before, we had the following:
Builders are now constructed like this: